Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The directory "dotgov-websites" is poorly named #67

Open
h-m-f-t opened this issue Aug 3, 2022 · 2 comments
Open

The directory "dotgov-websites" is poorly named #67

h-m-f-t opened this issue Aug 3, 2022 · 2 comments

Comments

@h-m-f-t
Copy link
Member

h-m-f-t commented Aug 3, 2022

While it's true that many of the hostnames in that folder are web-centric, not everything is, and we generally want to be technically accurate on the difference between .gov domains/hostname and .gov sites.

Look through cisagov projects that hardcode the path and update them.

h-m-f-t added a commit that referenced this issue Aug 3, 2022
@h-m-f-t
Copy link
Member Author

h-m-f-t commented Aug 3, 2022

@jsf9k @dav3r @mcdonnnj, I see cisagov/gatherer uses the files in our dotgov-websites directory. I've changed it to "misc" in a branch. That's a bit of a throwaway name, but I really just care that it's not inaccurate. I'm happy to make the change on my side and then file a PR on gatherer, but wanted to tag you for feedback.

@dav3r
Copy link
Member

dav3r commented Aug 3, 2022

@h-m-f-t If you want to make a PR, we would certainly appreciate it. There is one other place I found that will also need a PR.

We will need to coordinate the deployment of these changes so that our weekly report process doesn't break. Please let us know when you're planning to merge this directory name change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants