-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Response.resume() does not work #146
Comments
Oh I will push this fix and other fixes this week end, thanks for reporting! |
It's been a couple weeks, any progress here? Is there something I can do to help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The
resume()
method does not work on Response althoughpause()
does. I traced this down to the uWebSocketsuws_res_resume()
API callinguwsRes->pause()
instead ofuwsRes->resume()
. There was a bug filed there and just fixed: uNetworking/uWebSockets#1686To Reproduce
I reproduced by uploading a large file to a route. I was able to pause it correctly with
pause()
but I could never get it to resume withresume()
. It would always just remain stuck.I actually patched and rebuilt the uWebSocket
.so
libraries with the fix locally and it seems to work well.Expected behavior
The
resume()
should continue the upload after pausing.The text was updated successfully, but these errors were encountered: