Skip to content

Update image refs to use new tagging pattern #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HadrienPatte
Copy link
Member

@HadrienPatte HadrienPatte commented Jul 3, 2025

A new image tagging pattern based on a combination of timestamp and commit sha was introduced in #286 to allow renovate to order OCI image tags and update those refs. The refs that this PR updates are still using the old pattern so renovate is not able to update them. Hopefully, once this PR is merged, renovate will be able to start automatically updating those.

Note: as a result of updating the maker image, hadolint gets updated (see #337), meaning some hadolint checks failures must first be fixed

Related PRs:

@HadrienPatte HadrienPatte force-pushed the pr/HadrienPatte/image-tag branch 2 times, most recently from aba8213 to a785320 Compare July 4, 2025 12:48
Comment on lines +43 to +45
env:
DOCKER_HUB_PUBLIC_ACCESS_ONLY: true
QUAY_PUBLIC_ACCESS_ONLY: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is necessary for similar reasons as #283, without those, this step fails with:

Unable to find image 'linuxkit/binfmt:a17941b47f5cb262638cfb49ffc59ac5ac2bf334' locally
docker: error getting credentials - err: exit status 1, out: `ANY_REGISTRY_USERNAME is not set`

(example job)

@HadrienPatte HadrienPatte force-pushed the pr/HadrienPatte/image-tag branch 4 times, most recently from 9536820 to 5d7b9c3 Compare July 8, 2025 10:05
@HadrienPatte HadrienPatte force-pushed the pr/HadrienPatte/image-tag branch from 5d7b9c3 to a0c5901 Compare July 15, 2025 16:05
@HadrienPatte HadrienPatte force-pushed the pr/HadrienPatte/image-tag branch from a0c5901 to 3d65adf Compare July 16, 2025 08:43
@HadrienPatte HadrienPatte marked this pull request as ready for review July 16, 2025 13:29
@HadrienPatte HadrienPatte requested review from a team as code owners July 16, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants