Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity-check configuration file #248

Open
arter97 opened this issue Jun 21, 2022 · 1 comment
Open

Sanity-check configuration file #248

arter97 opened this issue Jun 21, 2022 · 1 comment

Comments

@arter97
Copy link

arter97 commented Jun 21, 2022

Hi, everyone.

I want to suggest a feature that's equivalent to Samba's testparm to sanity-check the configuration file.

While the documentation on Documentation/configuration.txt is quite comprehensive, it seems like ksmbd does not alert the users of any unrecognized values in the config file.

It would be a nice addition to ksmbd-tools (or ksmbd itself - e.g., warning in the kernel log) for new comers, migrating from other setups.

Thanks.

@namjaejeon
Copy link
Member

Agreed, Good suggestion:), samba also ignores unsupported parameters without a message. but ksmbd is a latecomer. As you said, it seems to be needed. Let me check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants