-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inclusion in scikit-mine #33
Comments
Hi, it is an interesting idea. As the maintainer, I may provide some help but it requires some effort estimation. If there any planning or scope so far? |
@chuanconggao thanks for responding, I think we can start with something "simple"
Rough estimation for this would be 2 weeks (my side) with daily feedback from you Once this is done, I would add another task
|
Sounds good. On my side, I can start some refactoring to make it more robust. |
@chuanconggao I wrapped your code and added a few unit tests in the PR mentioned above What sort of refactoring were you thinking of ? My implem is still missing the top-k part though ... which is interesting to have |
The refactoring part is mostly docstring, typing, and bug fixes. |
Hi there, very nice and rich implementation of these 3 algorithms
The INRIA center at Rennes is creating a new python library, namely scikit-mine, to centralise pattern mining methods, and improve inter-operability and consistency with other fields, such as Machine Learning.
Your API already has similarities with what scikit-mine provides, being:
In the context of scikit-mine, only BIDE and FEAT would be nice to have, as PrefixSpan mines too many patterns, and we encourage concise representations.
I also plan to try FEAT as a candidate generator for SQS-candidates, an algorithm based on MDL.
To this purpose handling gaps would be required, as SQS natively accounts them when running its optimization process
Anyone to provide support for integration into scikit-mine ?
The text was updated successfully, but these errors were encountered: