Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closer implementation of webBluetooth API #49

Open
derwehr opened this issue Nov 16, 2022 · 0 comments
Open

Closer implementation of webBluetooth API #49

derwehr opened this issue Nov 16, 2022 · 0 comments

Comments

@derwehr
Copy link
Contributor

derwehr commented Nov 16, 2022

In order to closer follow method signatures of the web bluetooth API, i propose the following changes:

  • argument of writeValue, writeValueWithResponse and writeValueWithoutResponse should be of type BufferSource
  • return type of readValue should be Promise<DataView>

This would make it easier to switch between web and node implementations.
I could implement this if you're interested in merging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@derwehr