Set maximal expires if session=false

Co-Authored-By: divinity76 <[email protected]>

Author: GrahamCampbell

CHANGELOG.md

@@ -1,6 +1,11 @@
 # CHANGELOG
 
 
+## 1.13.0 (UPCOMING)
+
+* Set maximal expires value if `session=false` in `Page::setCookies`
+
+
 ## 1.12.0 (2024-12-09)
 
 * Add PHP 8.4 support

src/Page.php

@@ -49,6 +49,8 @@ class Page
     public const LOAD = 'load';
     public const NETWORK_IDLE = 'networkIdle';
 
+    private const MAX_COOKIE_AGE = 60 * 60 * 24 * 365;
+
     /**
      * @var Target
      */
@@ -1086,6 +1088,11 @@ public function setCookies($cookies)
                 $browserCookie['domain'] = \parse_url($this->getCurrentUrl(), \PHP_URL_HOST);
             }
 
+            // set maximal expires if session=false
+            if (!isset($cookie['expires']) && ($cookie['session'] ?? null) === false) {
+                $browserCookie['expires'] = \time() + self::MAX_COOKIE_AGE;
+            }
+
             $browserCookies[] = $browserCookie;
         }