-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input focus lost when sibling is added to parent node. #86
Comments
Ah yeah, this might be because of
#85 too — the minimal amount of
change is to insert the h1 before the label, but instead it probably
creates two new elements. For some reason inserts _after_ the element
behave differrently. The issue linked should fix that, as the minimum
amount of changes would be taken (we could use help with that by the way!)
Hope this makes sense? Also re:testing — just writing a unit test where you
check if the elements are actually the same (e.g. moved vs recreated) would
probably be the way to do it. Think we have a few of those already :D
…On Thu, Oct 19, 2017 at 6:30 PM kj ***@***.***> wrote:
This is an edge case i discovered while using nanomorph "in anger".
What is the best way to test issues like these?
// initial state
<form>
<label for=stuff>
<input autofocus="autofocus" name="stuff">
</label>
</form>
// Updated state based on input interaction
<form>
<h1>YOU DID A THING!</h1>
<label for=stuff>
<input autofocus="autofocus" name="stuff">
</label>
</form>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#86>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWleiDPmkYYInoCZxk1F9nlHCYUy07Hks5st3kMgaJpZM4P_ghl>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is an edge case i discovered while using nanomorph "in anger".
What is the best way to test issues like these?
The text was updated successfully, but these errors were encountered: