Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The fate of computeCovarianceOfSums #353

Open
Lnaden opened this issue Feb 19, 2020 · 1 comment
Open

The fate of computeCovarianceOfSums #353

Lnaden opened this issue Feb 19, 2020 · 1 comment
Assignees
@mrshirts

Comments

@Lnaden
Copy link
Contributor

Lnaden commented Feb 19, 2020

In #347 , I raised the issue that the computeCovarianceOfSums function isn't well tested and currently unused anywhere in the code base. So as not to slow down that PR, I'm opening this issue.

There are two options:

  • Write a better statistical test for the function and/or possibly use it somewhere as suggested in the earlier discussion.
  • Remove it.
@mrshirts
Copy link
Collaborator

I will do a pass on this!

@mrshirts mrshirts self-assigned this Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrshirts mrshirts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Lnaden @mrshirts