Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should possibly try to trap this ComputeExpectation behavior #303

Open
mrshirts opened this issue Mar 19, 2018 · 0 comments
Open

Should possibly try to trap this ComputeExpectation behavior #303

mrshirts opened this issue Mar 19, 2018 · 0 comments
Assignees

Comments

@mrshirts
Copy link
Collaborator

If you use ComputeExpectations with a list of arrays (i.e. array([[ a, b , c]]) with state dependent = False, it misinterprets it as a 2D array, and passes it to kn_to_n, and overwrites the data.

Could possibly catch this error by checking if the shape of the list of arrays is internally consistent with N_k.

Not really a bug, but it's a case where bad data leads to a silent wrong answer, rather than stopping, which would be easier to catch.

@mrshirts mrshirts self-assigned this Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant