-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heretic: HHE end-of-episode flat renaming clashes with animated flats #1567
Comments
In the code it's defined as animated: I'm not sure why since it doesn't look like it animates or it's really subtle. But changing the |
The chocolate-doom/src/heretic/p_spec.c Line 184 in b33ff7e
chocolate-doom/src/heretic/f_finale.c Line 64 in b33ff7e
In Boom (but not Vanilla Doom) this problem was circumvented by introducing separate BEX pointers for the intermission background flats, e.g. I guess you'll have to apply another HHE rule to change the |
HHE should use separate pointers for strings in general. That's how the program works, it shouldn't be touching the string anywhere but the intermission flat listing when given those offsets. |
Background
Version of Chocolate Doom: built from Git repository 2023-01-02
Operating System and version: GNU/Linux (MX-19.4 "patito feo")
Game: Heretic
Any loaded WADs and mods (please include full command line):
chocolate-heretic -hhever 1.3 -deh e2end.hhe
Bug description
Observed behavior:
Startup halts with the following error:
P_InitPicAnims: bad cycle from FLAT516 to FLATHUH4
Expected behavior:
This patch should change the flat displayed behind the end-of-episode text for E2, and not touch animation cycles.
A similar patch for E1 (which works with both the original HHE and under chocolate, presumably since the E1 default flat isn't from an animation cycle) is also attached.
end-flat-hhes.zip
The text was updated successfully, but these errors were encountered: