Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes language server issue when empty file is removed from verible.filelist #2180

Merged
merged 1 commit into from
May 27, 2024
Merged

Fixes language server issue when empty file is removed from verible.filelist #2180

merged 1 commit into from
May 27, 2024

Conversation

sconwayaus
Copy link
Contributor

Resolves #2178

This PR resolves issue where removing an empty file from the verible.filelist causes the language server to stop.

@sconwayaus
Copy link
Contributor Author

Not sure why the arm64 CI tests are failing.

2024-05-09T11:04:04.8418356Z �[32;1m11:04:04�[0m | �[34;1m+ case "$MODE" in�[0m
2024-05-09T11:04:04.8421500Z �[32;1m11:04:04�[0m | �[34;1m+ bazel test --keep_going --cache_test_results=no --test_output=errors -c opt --noshow_progress --cxxopt=-fno-exceptions --cxxopt=-Werror --cxxopt=-W --cxxopt=-Wall --cxxopt=-Wextra --cxxopt=-Wunreachable-code --cxxopt=-Wno-unused-parameter --cxxopt=-Wno-missing-field-initializers --cxxopt=-Wno-redundant-move --cxxopt=-Wno-unused-label --cxxopt=-Wno-type-limits --cxxopt=-Wno-uninitialized //...�[0m
2024-05-09T11:04:04.8439829Z �[31;1m11:04:04�[0m | Extracting Bazel installation...
2024-05-09T11:04:10.9498966Z �[31;1m11:04:10�[0m | Starting local Bazel server and connecting to it...
2024-05-09T11:04:19.9469694Z �[31;1m11:04:19�[0m | 
2024-05-09T11:04:19.9471949Z �[31;1m11:04:19�[0m | Server terminated abruptly (error code: 14, error message: 'Socket closed', log file: '/root/.cache/bazel/_bazel_root/8f7974adf68934c9ed4690a59b110572/server/jvm.out')
2024-05-09T11:04:19.9502949Z �[31;1m11:04:19�[0m | 
2024-05-09T11:04:19.9660175Z ##[error]Process completed with exit code 37.
2024-05-09T11:04:19.9756215Z ##[group]Run actions/upload-artifact@v3

Any thoughts?

@IEncinas10
Copy link
Collaborator

It happened to me too, I wouldn't worry too much. I think owners of the repo can launch the testing pipeline again.

I guess if you add new commits it will launch itself again too

hzeller
hzeller approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@hzeller hzeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I wonder why an empty file is not properly indexed with its empty string, there must be something else that makes different assumptions depending on content.

Anyway, the CHECK() was only there to find out if this ever happend, and looks like it did :) Thanks for the fix and in particular for adding a teste.

@hzeller hzeller merged commit b28ed80 into chipsalliance:master May 27, 2024
32 of 33 checks passed
@sconwayaus sconwayaus deleted the filelist_remove_empty_file_bugfix branch May 30, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzeller hzeller hzeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

verible.filelist empty file exception
3 participants
@sconwayaus @IEncinas10 @hzeller