Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old code exceptions in HealthCheck should likely be deleted #1058

Open
lamont-granquist opened this issue Jan 22, 2022 · 1 comment
Open
Labels
Aspect: Packaging Distribution of the projects 'compiled' artifacts.

Comments

@lamont-granquist
Copy link
Contributor

when /^\s+libjvm.so/
next
when /^\s+libjava.so/
next
when /^\s+libmawt.so/
next

Those lines date back to the original code that Stephen Delano wrote and seem like they're subverting the health check in some way. They should probably be deleted. Then it should be validated that chef-server and automate and any other JVM-using apps still built correctly.

@lamont-granquist
Copy link
Contributor Author

Oh this might be because we don't build the JVM and ship binaries that violate omnibus containment principles and we decided that's acceptable?

If so it should probably get documented, and maybe those three things should be broken out into a CONSTANT value like the other whitelist (as its still called now) values.

@PrajaktaPurohit PrajaktaPurohit added the Aspect: Packaging Distribution of the projects 'compiled' artifacts. label Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aspect: Packaging Distribution of the projects 'compiled' artifacts.
Projects
None yet
Development

No branches or pull requests

2 participants