Fix bzip2 makefile_take_env_vars.patch for 1.0.8 patching #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makefile_take_env_vars.patch should only be applied if bzip2 version is 1.0.6. Patch fails to apply on 1.0.8. Obvious fix.
Quantu
changed the title
… for bzip-1.0.8 Obvious fix.
Quantu
changed the title
|
The issue is with the version of patch preinstalled on macos (even through 10.15.5 at least, doubt they will every update it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makefile_take_env_vars.patch fails to apply to Makefile on 1.0.8. Increase context so patch works for bzip2-1.0.8.
Fixes #1173
Obvious fix.
Description
Related Issue
Types of changes
Checklist: