-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression of #1040: cannot compile on macOS - bzip2 #1173
Comments
I took a closer look at @erikng's proposed solution in #1040, and it looks like he gave
|
The issue is with the very old version of patch preinstalled on macos (even through 10.15.5 at least, doubt they will ever update it). |
Version:
v7.0.7 (as supplied/installed by chef-workstation source code build steps)
Environment:
macOS 10.14.6, Ruby 2.6.5 (via rbenv)
While it does not appear to be an issue with chef-workstation, for the sake of completeness chef-workstation repo
master
branch and0.17.5
tag behave the same.Scenario:
Unable to build chef-workstation via omnibus. Possibly same issue discussed in omnibus-software #1040.
Steps to Reproduce:
a.
cd omnibus; bundle install --binstubs
b.
sudo bin/omnibus build chef-workstation
Expected Result:
Should have omnibus build a chef-workstation package.
Actual Result:
From what I can see it looks like omnibus downloads a chef published tarball for bzip2 v1.0.8. Later, just prior to compiling bzip2, omnibus attempts to patch the two bzip Makefiles
Makefile
andMakefile-libbz2_so
. The patch file itself,makefile_take_env_vars.patch
says it was created from bzip2 1.0.6.The build fails with error
Contents of
Makefile.rej
:The text was updated successfully, but these errors were encountered: