Wrong filename from a custom url

[fluxX04]

Version:

Using version ~> 3.11 from chef_client_updater v3.8.4

Environment:

Windows 10

Scenario:

I'm using the cookbook attribute download_url_override as url: https://my.cloud/index.php/s/8yo7sEwDoJf32TN/download?path=chef-client&files=chef-client-latest-x64.msi - to download the chef-client.

Steps to Reproduce:

Use a download url like above.

Expected Result:

Save and download the file with the correct filename and complete the chef upgrade.

Actual Result:

The filename gets resolved to Filename: download?path=chef-client&files=chef-client-latest-x64.msi and cannot be downloaded because of illegal chars in the path:

Downloading chef from https://my.cloud/index.php/s/8yo7sEwDoJf32TN/download?path=chef-client&files=chef-client-latest-x64.msi to C:\Users\myuser\AppData\Local\Temp\download?path=chef-client&files=chef-client-latest-x64.msi.

Filename should be: chef-client-latest-x64.msi

Code:

mixlib-install/lib/mixlib/install/generator/powershell/scripts/install_project.ps1.erb

Line 94 in 13bbdce

$filename = ($download_url -split '/')[-1]

PS:

$download_url = "https://my.cloud/index.php/s/8yo7sEwDoJf32TN/download?path=chef-client&files=chef-client-latest-x64.msi"
PS C:\opscode> ($download_url -split '/')[-1]
download?path=chef-client&files=chef-client-latest-x64.msi

Greetz

[fluxX04]

@tas50 @schisamo some progress here?

Greetz