Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix org full name truncation #216

Merged
merged 2 commits into from
Jan 12, 2018
Merged

Conversation

bkonick
Copy link
Contributor

@bkonick bkonick commented Jan 12, 2018

Description

Fixes org full name truncation.

Issues Resolved

Resolves #215

Check List

n/a - New functionality includes testing.
n/a - New functionality has been documented in the README if applicable

@bkonick bkonick requested a review from a team January 12, 2018 15:51
@bkonick
Copy link
Contributor Author

bkonick commented Jan 12, 2018

@wrightp looks like this failure didn't have anything to do with my changes? https://travis-ci.org/chef-cookbooks/chef-ingredient/jobs/328170547

Can you restart that one task to see if it was just an intermittent issue?

@bkonick
Copy link
Contributor Author

bkonick commented Jan 12, 2018

@wrightp all good now. Just failing on the DCO key but since it's an obvious fix I don't think I need that? I can amend the commit messages and force push to my fork if you like though.

@bkonick
Copy link
Contributor Author

bkonick commented Jan 12, 2018

Went ahead and amended the commit messages to pass the DCO check.

Copy link
Contributor

@ncerny ncerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

@bkonick
Copy link
Contributor Author

bkonick commented Jan 12, 2018

Thanks @ncerny and @wrightp !

Any chance we can get this merged today? I'd love to be able to use this from the Supermarket instead of having to point to my fork as a workaround.

@wrightp wrightp merged commit 374a0f8 into chef-cookbooks:master Jan 12, 2018
@bkonick bkonick deleted the org_full_name branch January 12, 2018 17:14
@wrightp
Copy link

wrightp commented Jan 12, 2018

Upload to supermarket. Thanks for getting it all prepped as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Org full name doesn't support spaces
3 participants