Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensitive property not passed down from top level resources #198

Closed
JOSEPHBODNAR opened this issue Aug 22, 2017 · 4 comments
Closed

sensitive property not passed down from top level resources #198

JOSEPHBODNAR opened this issue Aug 22, 2017 · 4 comments
Assignees
Labels
Status: Good First Issue An issue ready for a new contributor. Type: Bug Does not work as expected. Type: Enhancement Adds new functionality.

Comments

@JOSEPHBODNAR
Copy link

Cookbook version

2.1.7

Chef-client version

12.18.31

Platform Details

Suse12sp2

Scenario:

We are trying to hide the display of sensitive data (e.g. Ldap Passwords) from the chef-client run logs. We have set the 'sensitive' property to 'true' on the chef_server, chef_automate, chef_supermarket, and workflow_builder resources, but this property value is not being propagated to lower-level resources (e.g. chef_ingredient, ingredient_config) and the resulting config files are being fully displayed. From the code, it looks like ingredient_config is written to accept a value that would have been passed and would honor it when rendering the config file. In addition several generated sensitive files (e.g. delivery.pem, validation.pem, builder_key) are also fully displayed.

Steps to Reproduce:

Add the property (and value) "sensitive true" when defining any of chef_server, chef_automate, chef_supermarket, or workflow_builder resources.

Expected Result:

The resulting config file (e.g. chef-server.rb, automate.rb) is not displayed in the chef-client output run.

Actual Result:

The resulting config file (including all sensitive data) is fully displayed in the chef-client output.

@wrightp
Copy link

wrightp commented Aug 22, 2017

@JOSEPHBODNAR Would you mind submitting a PR to fix the issue? That would expedite the resolution. Thanks!

@wrightp wrightp added the Type: Bug Does not work as expected. label Aug 22, 2017
@tas50
Copy link
Contributor

tas50 commented Sep 9, 2017

I’m adding the Type: Jump In GitHub label to this issue. This is a great issue for someone to get their feet wet with and we’d love a PR to resolves the issue.

@wrightp wrightp added the Type: Enhancement Adds new functionality. label Sep 12, 2017
@wrightp
Copy link

wrightp commented Sep 12, 2017

This issue is in active development. It's a 2-part change. There is certainly an issue propagating the sensitive property to chef_ingredient/ingredient_config. The other issue is that the file and chef_file resources within the "stack" resources need to be configured to accept the sensitive property as well.

@wrightp
Copy link

wrightp commented Oct 5, 2017

merged

@wrightp wrightp closed this as completed Oct 5, 2017
@tas50 tas50 added Status: Good First Issue An issue ready for a new contributor. and removed Help: Good First Issue labels Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Good First Issue An issue ready for a new contributor. Type: Bug Does not work as expected. Type: Enhancement Adds new functionality.
Projects
None yet
Development

No branches or pull requests

4 participants