Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using extended metadata requires that both source_url and issues_url are set #81

Closed
jf647 opened this issue Aug 21, 2015 · 1 comment
Closed

Comments

@jf647
Copy link
Contributor

jf647 commented Aug 21, 2015

Supermarket (the app) will take the new extended metadata fields in any combo (source only, issues only, or both).

If you try to use stove to upload a cookbook that only has one of the extended metadata fields, it fails because it encodes the missing one as an empty hash in the JSON.

The fix seems simple - only populate the extended fields if the switch has been provided and the attribute is not empty.

PR to follow.

@directionless
Copy link
Contributor

This issue is still present, and results in the confusing error message:

{"error_code"=>"INVALID_DATA", "error_messages"=>["The metadata is formatted incorrectly.", "Multipart POST part 'tarball' must contain a non-empty README."]}

directionless added a commit to directionless/stove that referenced this issue Jun 16, 2016
Only populate the extended metadata when it's present in `metadata.rb`

Based on chef-boneyard#82

Closes chef-boneyard#81
Closes chef-boneyard#82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants