Skip to content

Commit 811e958

Browse files
remove sarama sasl 'mechanism' config and typo in KafkaTLSProducerEnabled
1 parent f797cb4 commit 811e958

File tree

2 files changed

+17
-34
lines changed

2 files changed

+17
-34
lines changed

kafka.go

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -90,13 +90,6 @@ func (om *OpenMock) saramaConsumerConfig() (config *cluster.Config, seedBrokers
9090
config.Net.SASL.Enable = true
9191
config.Net.SASL.User = saslUsername
9292
config.Net.SASL.Password = saslPassword
93-
94-
saslMechanism := om.KafkaSaslMechanism
95-
if om.KafkaSaslConsumerMechanism != "" {
96-
saslMechanism = om.KafkaSaslConsumerMechanism
97-
}
98-
99-
config.Net.SASL.Mechanism = sarama.SASLMechanism(saslMechanism)
10093
}
10194

10295
seedBrokers = om.KafkaSeedBrokers
@@ -110,7 +103,7 @@ func (om *OpenMock) saramaConsumerConfig() (config *cluster.Config, seedBrokers
110103
func (om *OpenMock) saramaProducerConfig() (config *sarama.Config, seedBrokers []string) {
111104
config = &sarama.Config{}
112105

113-
shouldEnableTLS := om.KafkaTLSProducerEnabeld || om.KafkaTLSEnabled
106+
shouldEnableTLS := om.KafkaTLSProducerEnabled || om.KafkaTLSEnabled
114107
if shouldEnableTLS {
115108
config.Net.TLS.Enable = true
116109
}
@@ -129,13 +122,6 @@ func (om *OpenMock) saramaProducerConfig() (config *sarama.Config, seedBrokers [
129122
config.Net.SASL.Enable = true
130123
config.Net.SASL.User = saslUsername
131124
config.Net.SASL.Password = saslPassword
132-
133-
saslMechanism := om.KafkaSaslMechanism
134-
if om.KafkaSaslProducerMechanism != "" {
135-
saslMechanism = om.KafkaSaslProducerMechanism
136-
}
137-
138-
config.Net.SASL.Mechanism = sarama.SASLMechanism(saslMechanism)
139125
}
140126

141127
seedBrokers = om.KafkaSeedBrokers

openmock.go

Lines changed: 16 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -27,25 +27,22 @@ type OpenMock struct {
2727
AdminHTTPHost string `env:"OPENMOCK_ADMIN_HTTP_HOST" envDefault:"0.0.0.0"`
2828

2929
// Kafka channel
30-
KafkaEnabled bool `env:"OPENMOCK_KAFKA_ENABLED" envDefault:"false"`
31-
KafkaClientID string `env:"OPENMOCK_KAFKA_CLIENT_ID" envDefault:"openmock"`
32-
KafkaSeedBrokers []string `env:"OPENMOCK_KAFKA_SEED_BROKERS" envDefault:"kafka:9092" envSeparator:","`
33-
KafkaSaslUsername string `env:"OPENMOCK_KAFKA_SASL_USERNAME" envDefault:""`
34-
KafkaSaslPassword string `env:"OPENMOCK_KAFKA_SASL_PASSWORD" envDefault:""`
35-
KafkaSaslMechanism string `env:"OPENMOCK_KAFKA_SASL_MECHANISM" envDefault:"PLAIN"`
36-
KafkaTLSEnabled bool `env:"OPENMOCK_KAFKA_TLS_ENABLED" envDefault:"false"`
37-
38-
KafkaProducerSeedBrokers []string `env:"OPENMOCK_KAFKA_PRODUCER_SEED_BROKERS" envDefault:"" envSeparator:","`
39-
KafkaSaslProducerUsername string `env:"OPENMOCK_KAFKA_SASL_PRODUCER_USERNAME" envDefault:""`
40-
KafkaSaslProducerPassword string `env:"OPENMOCK_KAFKA_SASL_PRODUCER_PASSWORD" envDefault:""`
41-
KafkaSaslProducerMechanism string `env:"OPENMOCK_KAFKA_SASL_PRODUCER_MECHANISM" envDefault:""`
42-
KafkaTLSProducerEnabeld bool `env:"OPENMOCK_KAFKA_TLS_PRODUCER_ENABLED" envDefault:""`
43-
44-
KafkaConsumerSeedBrokers []string `env:"OPENMOCK_KAFKA_CONSUMER_SEED_BROKERS" envDefault:"" envSeparator:","`
45-
KafkaSaslConsumerUsername string `env:"OPENMOCK_KAFKA_SASL_CONSUMER_USERNAME" envDefault:""`
46-
KafkaSaslConsumerPassword string `env:"OPENMOCK_KAFKA_SASL_CONSUMER_PASSWORD" envDefault:""`
47-
KafkaSaslConsumerMechanism string `env:"OPENMOCK_KAFKA_SASL_CONSUMER_MECHANISM" envDefault:""`
48-
KafkaTLSConsumerEnabled bool `env:"OPENMOCK_KAFKA_TLS_CONSUMER_ENABLED" envDefault:""`
30+
KafkaEnabled bool `env:"OPENMOCK_KAFKA_ENABLED" envDefault:"false"`
31+
KafkaClientID string `env:"OPENMOCK_KAFKA_CLIENT_ID" envDefault:"openmock"`
32+
KafkaSeedBrokers []string `env:"OPENMOCK_KAFKA_SEED_BROKERS" envDefault:"kafka:9092" envSeparator:","`
33+
KafkaSaslUsername string `env:"OPENMOCK_KAFKA_SASL_USERNAME" envDefault:""`
34+
KafkaSaslPassword string `env:"OPENMOCK_KAFKA_SASL_PASSWORD" envDefault:""`
35+
KafkaTLSEnabled bool `env:"OPENMOCK_KAFKA_TLS_ENABLED" envDefault:"false"`
36+
37+
KafkaProducerSeedBrokers []string `env:"OPENMOCK_KAFKA_PRODUCER_SEED_BROKERS" envDefault:"" envSeparator:","`
38+
KafkaSaslProducerUsername string `env:"OPENMOCK_KAFKA_SASL_PRODUCER_USERNAME" envDefault:""`
39+
KafkaSaslProducerPassword string `env:"OPENMOCK_KAFKA_SASL_PRODUCER_PASSWORD" envDefault:""`
40+
KafkaTLSProducerEnabled bool `env:"OPENMOCK_KAFKA_TLS_PRODUCER_ENABLED" envDefault:""`
41+
42+
KafkaConsumerSeedBrokers []string `env:"OPENMOCK_KAFKA_CONSUMER_SEED_BROKERS" envDefault:"" envSeparator:","`
43+
KafkaSaslConsumerUsername string `env:"OPENMOCK_KAFKA_SASL_CONSUMER_USERNAME" envDefault:""`
44+
KafkaSaslConsumerPassword string `env:"OPENMOCK_KAFKA_SASL_CONSUMER_PASSWORD" envDefault:""`
45+
KafkaTLSConsumerEnabled bool `env:"OPENMOCK_KAFKA_TLS_CONSUMER_ENABLED" envDefault:""`
4946

5047
// AMQP channel
5148
AMQPEnabled bool `env:"OPENMOCK_AMQP_ENABLED" envDefault:"false"`

0 commit comments

Comments
 (0)