Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a loading state to the ChecTable component #485

Open
ScopeyNZ opened this issue Jul 19, 2021 · 1 comment
Open

Add a loading state to the ChecTable component #485

ScopeyNZ opened this issue Jul 19, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@ScopeyNZ
Copy link
Contributor

ScopeyNZ commented Jul 19, 2021 •
edited

It's becoming pretty common-place for us to add a row with a loading indicator to a table, and define some stying for it. We should add this to the ChecTable component so we DRY it up:

https://github.com/chec/dashboard/blob/07b1ae185b3219b2c1ca8a90cca8e15e0af4849b/src/modules/settings/components/shipping/ZoneTable.vue#L145-L152

The only weird thing about this is that we'll need to tell the component how many columns are in the table.
@ScopeyNZ ScopeyNZ added the enhancement New feature or request label Jul 19, 2021
@robbieaverill
Copy link
Contributor

If only HTML supported something like colspan="*"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ScopeyNZ @robbieaverill