Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

React warnings for using value attribute #220

Open
robbieaverill opened this issue Sep 16, 2021 · 0 comments
Open

React warnings for using value attribute #220

robbieaverill opened this issue Sep 16, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@robbieaverill
Copy link
Contributor

In the checkout page we use set the value attribute directly on form fields without providing an onChange handler. This results in a number of React warnings in the console:

image

We should follow best practices for form field data binding. https://reactjs.org/docs/forms.html#controlled-components

@robbieaverill robbieaverill added the bug Something isn't working label Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant