-
Notifications
You must be signed in to change notification settings - Fork 44
Open
Labels
complexity: moderateTime needed to do this ticket will be moderate e.g. 1-2 daysTime needed to do this ticket will be moderate e.g. 1-2 daysjavascriptPull requests that update Javascript codePull requests that update Javascript codepriority: soonShould be prioritized soon.Should be prioritized soon.refactorstaleThis issue or PR is inactive.This issue or PR is inactive.state: approvedReady to go. Not blocked or pending.Ready to go. Not blocked or pending.
Milestone
Description
Overview
We have types which are prefixed with I[Type] such as IUser. We are moving to only using Entity types such as UserEntity in the services and UserDtos such GetUserDto in the controllers.
In cases where IUser is being used in the controller or the entity, convert to the appropriate type. Feel free to use Partials or Pick types if you think it is necessary but preferable to keep it clean and simple.
Action Items
List the research to be done and the steps to be completed.
- Take a look at UserEntity and the GetUserDto and at the IUser and see where they cross over.
- Replace all instances of IUser with appropriate types. If its not obvious, feel free to tag @eleanorreem or @annarhughes in the comment to ask any questions.
Metadata
Metadata
Assignees
Labels
complexity: moderateTime needed to do this ticket will be moderate e.g. 1-2 daysTime needed to do this ticket will be moderate e.g. 1-2 daysjavascriptPull requests that update Javascript codePull requests that update Javascript codepriority: soonShould be prioritized soon.Should be prioritized soon.refactorstaleThis issue or PR is inactive.This issue or PR is inactive.state: approvedReady to go. Not blocked or pending.Ready to go. Not blocked or pending.