@j4m3s-s thanks for the PR!

You should be able to override those values by doing something like --set strategy.type=Recreate --set strategy.rollingUpdate=null.

Indeed ! I completely forgot I could use null in that case. But I still think it should be a default. WDYT ?

Indeed ! I completely forgot I could use null in that case. But I still think it should be a default. WDYT ?

Gotcha! I’m not sure what benefits come with removing that as the default. Do you have any examples on why we would want to remove it? Thanks!

With the current number of replicas being 0, the default value for maxUnavailable is also 0. (25% rounded down as described here : https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/#rollingupdatedeployment-v1-apps).
So it's not really needed by default, unless it introduces some scaling issue at a high number of replicas ? (I never had the case but this might still be an issue).
And this allows for an easier switch between the two strategies.

What do you think ? Feel free to close it if you think it's not sufficient for a change like this.

@j4m3s-s thanks! I think this would be fine to remove as the default. Since the replica count is 1 by default, maxUnavailable should be 0 anyway.

To move forward with this, can you rebase with main and bump the chart version? (A patch bump should be fine)

@cbuto Done! Please tell me if there's anything else I should fix. Thanks for your time!

thanks @j4m3s-s, looks good!