Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 6.0.0 Deprecation warnings #279

Open
jhofstede opened this issue Sep 17, 2019 · 7 comments
Open

Rails 6.0.0 Deprecation warnings #279

jhofstede opened this issue Sep 17, 2019 · 7 comments

Comments

@jhofstede
Copy link

Just added impressionist to my Rails 6.0 (ruby 2.6.3) project found two deprecation warnings:

DEPRECATION WARNING: Initialization autoloaded the constant ImpressionistController.

Being able to do this is deprecated. Autoloading during initialization is going
to be an error condition in future versions of Rails.

Reloading does not reboot the application, and therefore code executed during
initialization does not run again. So, if you reload ImpressionistController, for example,
the expected changes won't be reflected in that stale Module object.

`config.autoloader` is set to `classic`. This autoloaded constant would have been unloaded if `config.autoloader` had been set to `:zeitwerk`.

Please, check the "Autoloading and Reloading Constants" guide for solutions.

And another one here

DEPRECATION WARNING: ActionDispatch::Http::ParameterFilter is deprecated and will be removed from Rails 6.1. Use ActiveSupport::ParameterFilter instead. (called from associative_create_statement at /Users/Julien/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/impressionist-1.6.1/app/controllers/impressionist_controller.rb:54)
@shayani
Copy link

shayani commented Oct 5, 2019

Me too. Already thinking about remove impressionist from my project :/

@t56k
Copy link

t56k commented Oct 10, 2019

Is this project abandoned?

@johnmcaliley
Copy link
Member

@cd-rum Not completely abandoned, but not actively maintained by anyone at this point. If anyone has a fix for this I’ll gladly merge a PR and push a new version so it’s rails 6 compatible. Also if anyone is interested in maintaining let me know and I’ll give you access.

@t56k
Copy link

t56k commented Oct 11, 2019

@johnmcaliley Thanks for the quick response, I'll consider it—I'm not sure my project actually requires it any longer is all, but that's a separate discussion obvs

@vadim-zverugo
Copy link

Rails 6.0.2.1 has breaking changes, so don't upgrade until the impressionist is fixed.

@ianzitow
Copy link

ianzitow commented Jan 2, 2020

Correct, locked in 6.0.2.

ShuheiOhno added a commit to takuhagi/myprofile that referenced this issue Oct 18, 2020
#What
・profilesテーブルにpv_countカラム 追加
・usersコントローラーで、users/showにアクセスするたびにpv_countが1つずつ増えるように処理を記載
・リンクがつき次第、カウントが正常に確認できるか再確認する必要あり。
・リロードしてもpv数+1

#Why
・pv数を保存するため
・gem(impressionist)は、rails5系から更新されていないため、使うのをやめました。
charlotte-ruby/impressionist#279
@juanpabloxk
Copy link

juanpabloxk commented Apr 21, 2023

I am getting this error when running any rspec command, in my case one workaround could be disabling class caching:

# config/environments/test.rb

Rails.application.configure do
  ...
  config.cache_classes = false
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants