-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 6.0.0 Deprecation warnings #279
Comments
Me too. Already thinking about remove impressionist from my project :/ |
Is this project abandoned? |
@cd-rum Not completely abandoned, but not actively maintained by anyone at this point. If anyone has a fix for this I’ll gladly merge a PR and push a new version so it’s rails 6 compatible. Also if anyone is interested in maintaining let me know and I’ll give you access. |
@johnmcaliley Thanks for the quick response, I'll consider it—I'm not sure my project actually requires it any longer is all, but that's a separate discussion obvs |
Rails 6.0.2.1 has breaking changes, so don't upgrade until the impressionist is fixed. |
Correct, locked in 6.0.2. |
#What ・profilesテーブルにpv_countカラム 追加 ・usersコントローラーで、users/showにアクセスするたびにpv_countが1つずつ増えるように処理を記載 ・リンクがつき次第、カウントが正常に確認できるか再確認する必要あり。 ・リロードしてもpv数+1 #Why ・pv数を保存するため ・gem(impressionist)は、rails5系から更新されていないため、使うのをやめました。 charlotte-ruby/impressionist#279
I am getting this error when running any rspec command, in my case one workaround could be disabling class caching: # config/environments/test.rb
Rails.application.configure do
...
config.cache_classes = false
end |
Just added impressionist to my Rails 6.0 (ruby 2.6.3) project found two deprecation warnings:
And another one here
The text was updated successfully, but these errors were encountered: