Skip to content

Applying github-review-approve with no comments fails #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
stsquad opened this issue Nov 15, 2021 · 0 comments
Open

Applying github-review-approve with no comments fails #92

stsquad opened this issue Nov 15, 2021 · 0 comments

Comments

@stsquad
Copy link

stsquad commented Nov 15, 2021

I can't quite follow the logic of github-review-submit-review but I can't see it calling either github-review-post-review-replies or github-review-post-review when I haven't added any additional comments and I just want to approve the PR. Some modest instrumenting of the two legs and I see:

Submitting review, this may take a while ...
ghr-prr: t nil
ghr-rpr: nil nil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stsquad