Skip to content

PR changed files list & clickable filenames #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rakanalh opened this issue Feb 20, 2019 · 2 comments
Open

PR changed files list & clickable filenames #2

rakanalh opened this issue Feb 20, 2019 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@rakanalh
Copy link

rakanalh commented Feb 20, 2019

It would be great if the package can also show the list of files that have been changed. Also the file names / hunks should be clickable to be able to navigate to the file's place of change quickly.

Edit: This is similar to what magit offers

@charignon
Copy link
Owner

charignon commented Feb 23, 2019

To investigate this, I would start looking at patch support in magit and see if we can find a minor mode that would give us that kind of capabilities (folding a diff and navigate through it quickly):

  • If such feature exists we can it enable in the case where the PR belongs to a repo checked out locally already (see Review code while the PR's branch is checked out #1)
  • If it does not exist, I would look at adding it to the magit mode for patches and leverage it here.

@charignon charignon added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Mar 9, 2019
@yqrashawn
Copy link

Also it'll be great if the diff of hunks and files can be toggle between expanded and collapsed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants