Panda CSS + ReScript

[vmarcosp]

Hey everyone!
I'm trying to create ReScript bindings (similar to type definitions in TypeScript) for Panda but I'm facing a issue with the generated code (generated by the ReScript compiler). I'll not share the bindings because this is not relevant for the question, but the generated code is something like that:

import * as React from "react";
import * as PandaCSS from "./styled-system/css";
import * as Client from "react-dom/client";

import './index.css';

function App(props) {
    return React.createElement("div", {
        className: PandaCSS.css({
            display: "block"
        })
    }, "Hello");
}

Checking the devtools and HTML, I can see the element with the proper class applied, but the element doesn't have the display:block styles as you can see here:

Changing the PandaCSS import from import * as PandaCSS from "./styled-system/css" to `import { css } from "./styled-system/css" eveything works as expected. My question here is: The css functions (and other utlities) should be always imported as named imports? That's why the original generated code isn't working?
Thanks in advance.

[astahmer]

you're right, currently the static extractor does not handle namespace imports !

is that a blocker for you ? I could look into implementing it if needed

[vmarcosp]

Thanks for answering @astahmer.
Yep, it's a blocker, but it's not that urgent. Additionally, I'd like to contribute to the project by adding support for namespace imports. I can open an issue and try to start with a small PR.

[astahmer]

awesome ! the related code is around here

panda/packages/parser/src/import.ts

Line 29 in 8a3bf6d

export function getImportDeclarations(

[vmarcosp]

Great. I was looking at extractor/extract.ts to see where the css(...) function call get its arguments extracted to static CSS: https://github.com/chakra-ui/panda/blob/main/packages/extractor/src/extract.ts#L162.
Debugging using the same code I provided in the examples, I realized that the fnName doesn't match the css function name as expected. Should I add support for namespace imports in this part as well?

[astahmer]

hm I'm not sure why the extractor needs to be touched but go ahead if you feel like it's needed as well !

[segunadebayo]

Namespace imports are now supported in Panda 🎉