-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(v2): styles removed when Nextjs (app) rehydrates #9593
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 43b41c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
__unsafe_useEmotionCache
Instead of withEmotionCache
__unsafe_useEmotionCache
Instead of withEmotionCache
isBatak
commented
Feb 2, 2025
__unsafe_useEmotionCache
Instead of withEmotionCache
@isBatak can you rebase this? and I'll have it merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9579
📝 Description
This PR updates the implementation to use
__unsafe_useEmotionCache
instead ofwithEmotionCache
, as Chakra UI injects CSS into the document head for certain transitions, requiring a nonce.__unsafe_useEmotionCache
hook. Reference__unsafe_useEmotionCache
is labeled "unsafe" because it may break Emotion’s automatic SSR support. However, in this case, Chakra UI's logic runs exclusively on the client, making this usage safe. On the server, the hook simply returnsnull
. Changelog Reference⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
Users should update Emotion to v11.14.0