Codecov Report

Merging #401 (36ce470) into main (91580d6) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
- Coverage   67.82%   67.82%   -0.01%     
==========================================
  Files          75       75              
  Lines        7777     7786       +9     
==========================================
+ Hits         5275     5281       +6     
- Misses       1819     1821       +2     
- Partials      683      684       +1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91580d6...36ce470. Read the comment docs.

Testing release.yaml workflow now by changing the import path and creating a new release in a separate repository.

find . \( -type d -name .git -prune \) -o -type f -print0 | xargs -0 sed -i 's:genjidb/genji:tie/genji-release-test:g'
go mod tidy
(cd engine/badgerengine && go mod tidy)
(cd cmd/genji && go mod tidy)

Looks like gorelease silently ignores replace directive. I’ll add a rollback strategy and run gorelease for badgerengine in a separate job after tagging root module.

@asdine should be ready for review.

Thanks @tie ! I will review ASAP

This looks good !

would you be able to add the tinygo wasm target into the matrix ?

@tie That's a lot of good work you poured into making this work! And those things are not fun to debug either, thank you so much for taking the time to make it work.

I experimented with the process and it works really nicely. AFAIU, with this PR the development process becomes the following:

1. Classic PR and merge onto the main branch, as usual
2. When it's time to release, git push origin main:release to trigger the release workflow
3. This opens a PR from release-vX.Y.Z to release where we can review the updates to all go.mod (and go.sum files).
4. We turn the release draft that was automatically created, which triggers the release assets workflow
5. The build matrix runs and attaches the assets
6. Drop the release branch?

Additionally, version bump commits are only reachable from tags so it should be safe to dispatch the workflow on main branch.

So that means, we'd be stuck with https://github.com/genjidb/genji/pull/401/files#diff-f94dd260d5f8f1b19caefcdfefe9ad1ab0cdfc040cd655cc82367b6950da9a0dR9 "forever" unless we rebase the release branch onto `main.

➡️ I don't think that's an issue, but I just wanted to be 100% sure I understand how we should handle the release branch. Could you confirm or correct me here?

Short feedback on minor things:

➡️ Optionally, what about zipping the binaries assets from the build matrix before uploading them on GH?

➡️ Could you squash the commits before we merge this PR? There are 54 of them and most of them are internal iterarations that do not bring any value to be kept as is in the commit history. Don't bother, there's the squash and merge button.

PS: thanks for taking the time to write this comment, it saved me some time 😊 #401 (comment) !

@tie Zipping things aside which is not important, could you just confirm what is the expected flow with the release branch?

After discussing with @asdine, we have decided to not merge this pull-request. This decision has nothing to do with the quality of your contribution, which is absolutely great!

➡️ What motivates our decision is that at this stage, Genji is still small and we aren't releasing often enough to justify adding an automated release mechanism and having to own that particular code.

I'll keep a bookmark to this PR because it's a great example of what can be achieved with Github actions. I hope this come out as not too disappointing due to how much energy was invested here.