Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add go binaries to the release #269

Open
asdine opened this issue Oct 17, 2020 · 6 comments
Open

Automatically add go binaries to the release #269

asdine opened this issue Oct 17, 2020 · 6 comments
Assignees
Labels
cli Command line

Comments

@asdine
Copy link
Collaborator

asdine commented Oct 17, 2020

Whenever we release a new version of the CLI, we should automatically compile the binary for Linux, macos and windows, 32 and 64 bits and upload them to the Github release.

@asdine asdine added the cli Command line label Oct 17, 2020
@tie
Copy link
Contributor

tie commented Oct 17, 2020

I have a WIP PoC on release branch using GitHub Actions.

First a workflow is triggered either on manual dispatch, or on tag push. It runs gorelease tool to check whether the new version is a valid semver release (i.e. there are no breaking changes). It then creates a draft release with the changelog from gorelease.

When the draft is published, it creates a new tag (if it does not exist) and another workflow is triggered that builds and uploads. release assets.

Also, I haven't tested that on 32-bit x86, but it looks like BadgerDB fails to compile on 32-bit ARM.

@asdine
Copy link
Collaborator Author

asdine commented Oct 17, 2020

@tie that workflow seems great, can't wait to see it in action!
Regarding compiling targets, it would be great to have arm 64 bits and wasm as well

@tie
Copy link
Contributor

tie commented Oct 17, 2020 via email

@asdine
Copy link
Collaborator Author

asdine commented Oct 17, 2020

Come to think of it, let's not deal with wasm for now. I still have trouble testing it correctly, but once https://github.com/genjidb/genji.js will be more mature we'll probably find a way to do that properly.

@asdine asdine added this to the v0.10.0 milestone Nov 12, 2020
@asdine asdine modified the milestones: v0.10.0, v0.11.0 Jan 26, 2021
@asdine asdine modified the milestones: v0.11.0, v0.12.0 Mar 24, 2021
@asdine
Copy link
Collaborator Author

asdine commented Apr 1, 2021

@tie are you still interested in this one?

@tie
Copy link
Contributor

tie commented Apr 2, 2021

Sure, I’ll look into it this weekend! I think I had a (mostly) working workflow back then, though I’m sure I’d want to make some simplifications now.

@asdine asdine removed this from the v0.12.0 milestone May 1, 2021
@tie tie mentioned this issue May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Command line
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants