Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are nested subqueries allowed? #263

Open
sandeep-biddala opened this issue Oct 15, 2020 · 4 comments
Open

Are nested subqueries allowed? #263

sandeep-biddala opened this issue Oct 15, 2020 · 4 comments

Comments

@sandeep-biddala
Copy link

Are nested subqueries like the following allowed?

SELECT 
    customerName
FROM
    customers
WHERE
    customerNumber NOT IN (SELECT DISTINCT
            customerNumber
        FROM
            orders);

This is not mentioned in the doc.

Also, the docs mention that the min supported Go version is 1.12. However I had a problem with running the project with Go 1.12. The problem seems to be because of the usage errors.Is function which was only introduced in 1.15

Great job with the project BTW. I am enjoying it!

@tdakkota
Copy link
Contributor

For now, subqueries and SELECT DISTINCT are not supported.

@asdine
Copy link
Collaborator

asdine commented Oct 17, 2020

Also, the docs mention that the min supported Go version is 1.12. However I had a problem with running the project with Go 1.12. The problem seems to be because of the usage errors.Is function which was only introduced in 1.15

Thanks for reporting it @sandeep-biddala !

@tie
Copy link
Contributor

tie commented Oct 17, 2020

The problem seems to be because of the usage errors.Is function which was only introduced in 1.15

Thanks for reporting it! One small note—errors.Is was introduced in Go 1.13.

@asdine do we have any policy on supporting different Go releases? E.g. Go project maintains the last two major releases (currently that’s 1.14 and 1.15, and that’s also what we test on Travis).

I think 1.12 was min because of some v2 dependencies that just don’t work without module support (i.e. v2 is not a subdirectory in the repo).

@asdine
Copy link
Collaborator

asdine commented Oct 17, 2020

Our default policy was to maintain it for the last two major releases, but I'm open to suggestions.
For now, since the project is still in the development phase, I'd like to limit friction as much as possible, so anything that is a good fit for both early adopters and for contributors works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants