-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
6 additions
and
3 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -71,5 +71,6 @@ | |
}, | ||
"engines": { | ||
"node": ">= 12" | ||
} | ||
}, | ||
"version": "2.0.1" | ||
} |
27ad8ba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keithamus this should have been released with a new major version, it fails our builds due to the previous commit about converting project to an ES module.
27ad8ba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry yeah I thought that was an already released major in 2.0. I'll fix.
27ad8ba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmozcelik I've published
2.0.2
. Please let me know if that works for you.27ad8ba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keithamus please consider marking
2.0.1
deprecated in favor of2.0.2
. We upgraded to2.0.1
to get rid of the security alert, but we should've upgraded to2.0.2
instead. We didn't realize this broke parts of our code, and then debugging the issue was difficult.A deprecation warning would make easier for devs who upgrade to
2.0.1
to know that they should use2.0.2
instead.27ad8ba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, it's now marked as deprecated https://www.npmjs.com/package/get-func-name/v/2.0.1.