-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to typescript #1567
Draft
43081j
wants to merge
12
commits into
chaijs:main
Choose a base branch
from
43081j:typescript
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Aug 31, 2024
-
This is an initial attempt at migrating the codebase to typescript. The tests and build should pass but we can go further and do more with the types. WIP until we do that.
Configuration menu - View commit details
-
Copy full SHA for ccd7706 - Browse repository at this point
Copy the full SHA ccd7706View commit details -
fix: use
never
for method argsThis way, we can hold them in a non-generic array without the need for `any`. Later, when we need to call the method, we will have to cast it to a callable signature.
Configuration menu - View commit details
-
Copy full SHA for 4beb6f5 - Browse repository at this point
Copy the full SHA 4beb6f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e614bd - Browse repository at this point
Copy the full SHA 7e614bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c0e656 - Browse repository at this point
Copy the full SHA 5c0e656View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8c24a1 - Browse repository at this point
Copy the full SHA c8c24a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b98008 - Browse repository at this point
Copy the full SHA 9b98008View commit details -
Configuration menu - View commit details
-
Copy full SHA for 133e05c - Browse repository at this point
Copy the full SHA 133e05cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50ded4d - Browse repository at this point
Copy the full SHA 50ded4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e175899 - Browse repository at this point
Copy the full SHA e175899View commit details -
Configuration menu - View commit details
-
Copy full SHA for 941cbe8 - Browse repository at this point
Copy the full SHA 941cbe8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e165b2 - Browse repository at this point
Copy the full SHA 2e165b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for aedefa2 - Browse repository at this point
Copy the full SHA aedefa2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.