Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prettier and eslint #328

Merged
merged 10 commits into from
May 23, 2024
Merged

feat: add prettier and eslint #328

merged 10 commits into from
May 23, 2024

Conversation

Trickfilm400
Copy link
Contributor

Hi,

Based on #310 (comment) here is a follow-up PR with prettier and a simple eslint configuration for styling the project files

Can we do a 5.0.0 release after this, so the NPM package corresponds to the current readme? Could be confusing otherwise. (the pipeline seems broken, issue seems like a wrong NPM token, therefore the 401 error, FWIK)

Changes:

  • add eslint, eslint-plugin-mocha, prettier
  • run prettier on all files
  • update a re-export of is-ip

First step for #318

/cc @43081j

@43081j
Copy link
Contributor

43081j commented May 22, 2024

could you possibly copy the prettier config from chai-as-promised:
https://github.com/chaijs/chai-as-promised/blob/master/.prettierrc.json

if we decide to change some preferences, at least the repos are in sync then

ill open a separate PR to sort the publishing

package.json Outdated Show resolved Hide resolved
eslint.config.mjs Outdated Show resolved Hide resolved
lib/net.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@43081j
Copy link
Contributor

43081j commented May 22, 2024

one last comment, could you also add the editorconfig from here:
https://github.com/chaijs/chai-as-promised/blob/master/.editorconfig

looks good to me then 👍 super nice work 🙏

@keithamus keithamus merged commit bd11864 into chaijs:main May 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants