-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add prettier and eslint #328
Conversation
build: add prettier to devDependencies
could you possibly copy the prettier config from chai-as-promised: if we decide to change some preferences, at least the repos are in sync then ill open a separate PR to sort the publishing |
one last comment, could you also add the editorconfig from here: looks good to me then 👍 super nice work 🙏 |
Hi,
Based on #310 (comment) here is a follow-up PR with prettier and a simple eslint configuration for styling the project files
Can we do a 5.0.0 release after this, so the NPM package corresponds to the current readme? Could be confusing otherwise. (the pipeline seems broken, issue seems like a wrong NPM token, therefore the 401 error, FWIK)
Changes:
is-ip
First step for #318
/cc @43081j