Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Ask CFPB-specific redirect functionality? #7199

Open
csebianlander opened this issue Aug 23, 2022 · 0 comments
Open

Removing Ask CFPB-specific redirect functionality? #7199

csebianlander opened this issue Aug 23, 2022 · 0 comments

Comments

@csebianlander
Copy link
Contributor

So right now there are actually three ways to set up redirects on CF.gov (I'm ignoring the urls.py approach that came up in a recent issue/PR because it shouldn't actually be used for this reason):

  1. Wagtail administration for one-off static redirects
  2. redirects.conf for RegEx/wildcard-based redirects
  3. Wagtail redirects set up specifically for Ask CFPB

The third category is weird and causes a number of reporting or functionality issues:

  1. These redirects do not show up in our standard redirects export, making them hard to track and cross-reference with our larger set of redirects
  2. Though the Ask CFPB data export does include these redirects, it does so in an odd, indirect way that requires several additional steps to properly render in the same manner as our usual redirects report
  3. I think Wagtail is treating pages redirected in this category as still existing/live on the website, which leads to some odd issues including, among other things, the existence of duplicate/redirected URLs in our sitemap.xml file

I do not know why the Ask section originally had redirects set up uniquely in this way -- probably to let content managers who were handling those pages set up redirects without having to interact with the Admin panel areas -- but I think it's at best duplicative and unnecessary now, and at worst actively causes confusion and harm to the site structure and ability to report on and maintain Ask CPFB over time.

Using the Ask CFPB export data, I've created a redirects CSV that can be mass-imported into Wagtail. (The total count is 357 redirects set up this way, including English and Spanish) Before I commit to doing that, though, I want to understand where there are any legitimate use-cases for keeping Ask redirects as-is and, if not, what the technical lift would be to remove that field/functionality entirely from those page types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant