Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce duplication in jinja2 templates #5546

Open
wpears opened this issue Mar 4, 2020 · 1 comment
Open

Reduce duplication in jinja2 templates #5546

wpears opened this issue Mar 4, 2020 · 1 comment
Labels
[issue-type] enhancement refactoring - code quality

Comments

@wpears
Copy link
Member

wpears commented Mar 4, 2020

As pages have been introduced over time, they've often liberally borrowed from other templates with the same desired layout/behavior. As such, we are now moderately afflicted with a case of templatus duplicatus. It would likely be worthwhile to do a readthrough of the current templates to see where common functionality could be extracted and packaged into a shared template.

See #5523 (comment) for two examples of template duplication.
@anselmbradford
Copy link
Member

Related [ghe]/CFGOV/platform/issues/3226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[issue-type] enhancement refactoring - code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anselmbradford @wpears