Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceNotificationPolicy implementation needs a rethink #386

Open
pacphi opened this issue Aug 5, 2021 · 0 comments
Open

ResourceNotificationPolicy implementation needs a rethink #386

pacphi opened this issue Aug 5, 2021 · 0 comments
Labels
feature New feature or request

Comments

@pacphi
Copy link
Collaborator

pacphi commented Aug 5, 2021

The design of ResourceNotificationPolicyExecutorTask and ResourceNotificationPolicy only really allow for existence matching. Label values in ResourceEmailMetadata are just email accounts which have an email domain appended.

What if we wanted to apply multiple labels to a resource and then find all resources matching a selector (which could be a combination of label key-value pair conditions), then notify an owner/designee? See selector requirement examples in table here.

The current implementation does not support this use case.

What we really want to be able to do is to notify someone (a notifyee) of a resource matching a selector.

So, maybe, if we consistently applied a label key notifyee where the value is always an email account or distribution-list alias stripped of its domain along with any other combo of label key-value pairs to a supported ResourceType, we could use that to send notifications. Perhaps we make a notifyee label-key configurable (per policy definition)?

@pacphi pacphi added the feature New feature or request label Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant