-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase e2e test timeouts #129
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently timeouts for checking for success are scattered across tests (e.g. here) and so are hard to change.
They're also quite low and could easily flake in a resource constrained testing environment.
It would be better to have a single const controlling global timeouts to make this easier to change and to make it obvious what's happening.
The above linked code block could be rewritten to:
Note that this also passes the context into the
Eventually
function which would be useful if we were to enforce a global timeout on all e2e tests in the futureThe text was updated successfully, but these errors were encountered: