Replies: 2 comments
-
I made PR #3863 to enable this based on this morning's standup. I think I wrote the code to support not commenting on a PR in the hours before the standup (based on input from microsoft/PowerToys, keptn/keptn, and the suggestion here). Fwiw, microsoft/PowerToys indicated they prefer the eager comments (I offered a way to suppress them for drafts). |
Beta Was this translation helpful? Give feedback.
0 replies
-
I'll bring up this topic during tonight's biweekly dev meeting, see this agenda entry |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Working on #3444, I realized that I do many orthographic and grammar mistakes 😇 Using something like @jsoref's check-spelling would help us deliver saner code. I am aware that check-spelling only focuses on orthographic mistakes, but that could be a good start. I personally heavily rely on Grammarly (I wish it also worked on! code 😅 )
By default, check-spelling adds in-code comments on the PRs:
The general consensus among the cert-manager seems to be that we don't want another source of PR noise. Could we, for example, use the action but disable the in-code PR comments? The build would still fail, and the PR author would have to look at the build logs in order to see which orthographic mistakes they made.
Beta Was this translation helpful? Give feedback.
All reactions