Skip to content

fix: validate type matches resource type for sparse fieldsets #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/jsonapi/request.rb
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,7 @@ def parse_fields(resource_klass, fields)
if type_resource.nil?
fail JSONAPI::Exceptions::InvalidResource.new(type, error_object_overrides)
else
verify_type(type, type_resource)
unless values.nil?
valid_fields = type_resource.fields.collect { |key| format_key(key) }
values.each do |field|
Expand Down
24 changes: 24 additions & 0 deletions test/unit/jsonapi_request/jsonapi_request_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,30 @@ def test_parse_dasherized_with_underscored_include
assert_equal 'iso_currency is not a valid includable relationship of expense-entries', request.errors[0].detail
end

def test_parse_fields_singular
params = ActionController::Parameters.new(
{
controller: 'expense_entries',
action: 'index',
fields: {expense_entry: 'iso_currency'}
}
)

request = JSONAPI::Request.new(
params,
{
context: nil,
key_formatter: JSONAPI::Formatter.formatter_for(:underscored_key)
}
)

e = assert_raises JSONAPI::Exceptions::InvalidResource do
request.parse_fields(ExpenseEntryResource, params[:fields])
end
refute e.errors.empty?
assert_equal 'expense_entry is not a valid resource.', e.errors[0].detail
end

def test_parse_fields_underscored
params = ActionController::Parameters.new(
{
Expand Down
Loading