From a381856f79f16a9f4bde3c0af9acf278f2d06738 Mon Sep 17 00:00:00 2001 From: Matt Benjamin Date: Tue, 9 Apr 2024 16:02:06 -0400 Subject: [PATCH] make create-then-list test idempotent I think s3-tests does not promise this in general, but some of its primitives (e.g., generating unique bucket and object names) tend in that direction. affected: * test_buckets_create_then_list Signed-off-by: Matt Benjamin --- s3tests_boto3/functional/test_s3.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/s3tests_boto3/functional/test_s3.py b/s3tests_boto3/functional/test_s3.py index d5ab01a2..0a80e1b2 100644 --- a/s3tests_boto3/functional/test_s3.py +++ b/s3tests_boto3/functional/test_s3.py @@ -5298,15 +5298,19 @@ def test_buckets_create_then_list(): def test_buckets_list_ctime(): # check that creation times are within a day before = datetime.datetime.now(datetime.timezone.utc) - datetime.timedelta(days=1) - + buckets_list = [] client = get_client() + for i in range(5): - client.create_bucket(Bucket=get_new_bucket_name()) + bucket_name = get_new_bucket_name() + client.create_bucket(Bucket=bucket_name) + buckets_list.append(bucket_name) response = client.list_buckets() for bucket in response['Buckets']: - ctime = bucket['CreationDate'] - assert before <= ctime, '%r > %r' % (before, ctime) + if bucket['Name'] in buckets_list: + ctime = bucket['CreationDate'] + assert before <= ctime, '%r > %r' % (before, ctime) @pytest.mark.fails_on_aws def test_list_buckets_anonymous():