Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support VERSION=8 for contrib/compose-rhcs.sh #2209

Closed
ktdreyer opened this issue May 22, 2024 · 0 comments
Closed

support VERSION=8 for contrib/compose-rhcs.sh #2209

ktdreyer opened this issue May 22, 2024 · 0 comments
Assignees
@guits

Comments

@ktdreyer
Copy link
Member

Would you please push the necessary changes to this project so that we can create the redhat and ibm containers for 8?

BRANDING=redhat VERSION=8 ./contrib/compose-rhcs.sh
BRANDING=ibm VERSION=8 ./contrib/compose-rhcs.sh

These commands generate Dockerfiles, but the Dockerfiles have some errors in the contents:

  1. version says 6 instead of 8
  2. __DOCKERFILE_BRANDING__ is not applied
guits added a commit that referenced this issue May 28, 2024
@guits
ubi: add squid release
6cc0c0f 
This allows building redhat and ibm containers for 8 (squid)

Fixes: #2209

Signed-off-by: Guillaume Abrioux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guits guits

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ktdreyer @guits