Not possible to run rolling update from Quincy to Reef (Stable-8.0) with a custom cluster name

[ksr82]

Bug Report

The tasks
ceph-ansible/infrastructure-playbooks/rolling_update.yml -> name: Set cluster configs
/ceph-ansible/roles/ceph-mon/tasks/main.yml -> name: Set cluster configs

Fail durring rolling update from Quincy to Reef if cluster name is different from "ceph"

What you expected to happen:
I would expect the tasks to take the cluster variable in the group_vars/all.yml into account

I was able to fix it by adding: cluster: "{{ cluster }}" to the tasks like so:

• name: Set cluster configs
  ceph_config:
  action: set
  who: "{{ item.0.key }}"
  option: "{{ item.1.key }}"
  value: "{{ item.1.value }}"
  cluster: "{{ cluster }}"
  when: item.1.value != omit
  loop: "{{ ceph_cluster_conf | dict2dict }}"
  environment:
  CEPH_CONTAINER_IMAGE: "{{ ceph_docker_registry + '/' + ceph_docker_image + ':' + ceph_docker_image_tag if containerized_deployment | bool else None }}"
  CEPH_CONTAINER_BINARY: "{{ container_binary }}"

I would love to fix it myself and create a pull request for it, but I can't figure out how to - Seems like I'm not allowed to push brances to the project.

[guits]

As far as I can tell, custom cluster names have not been supported for quite a while.
That being said the code still allows to do that, I believe.

I would love to fix it myself and create a pull request for it, but I can't figure out how to - Seems like I'm not allowed to push brances to the project.

You need to fork the repository and create your own branch, then submit a pull request from your branch targeting the main branch of ceph-ansible