fix: add fees in TT price calculation #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustermeiszer
added
the
D0-ready
lemunozm
approved these changes
Sep 11, 2024
| let nav = Nav::new(nav_loans, nav_fees); | ||
| let total_assets = nav | ||
| .total(pool.reserve.total) | ||
| .unwrap_or(<T as Config>::Balance::zero()); |
There was a problem hiding this comment.
Super NIT: unwrap_or_default()
There was a problem hiding this comment.
I am not the biggest fan of default in these case. Zero is really explicit and also what we want.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1990 +/- ##
==========================================
+ Coverage 48.19% 48.22% +0.02%
==========================================
Files 183 183
Lines 13403 13406 +3
==========================================
+ Hits 6460 6465 +5
+ Misses 6943 6941 -2 ☔ View full report in Codecov by Sentry. |
|
Why did the pipeline fcancel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See issue
Fixes #1989
Changes and Descriptions
Checklist: