Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add update tranche hook extrinsic #1954

Merged
merged 2 commits into from
Aug 10, 2024

Conversation

wischli
Copy link
Contributor

@wischli wischli commented Aug 9, 2024

Description

  • Adds extrinsic to update the domain tranche hook address for EVM

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@wischli wischli added the I8-enhancement An additional feature. label Aug 9, 2024
@wischli wischli self-assigned this Aug 9, 2024
Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not be more perfect a PR! Not a single NIT

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 68.88889% with 14 lines in your changes missing coverage. Please review.

Project coverage is 48.13%. Comparing base (1e318e2) to head (78a6006).

Files Patch % Lines
pallets/liquidity-pools/src/lib.rs 56.00% 11 Missing ⚠️
pallets/liquidity-pools/src/defensive_weights.rs 0.00% 2 Missing ⚠️
pallets/liquidity-pools/src/tests.rs 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1954      +/-   ##
==========================================
+ Coverage   48.07%   48.13%   +0.06%     
==========================================
  Files         183      183              
  Lines       12884    12926      +42     
==========================================
+ Hits         6194     6222      +28     
- Misses       6690     6704      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wischli wischli merged commit ffed149 into main Aug 10, 2024
13 of 14 checks passed
@lemunozm lemunozm deleted the lp-v2/update-tranche-hook-extrinsic branch August 10, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I8-enhancement An additional feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants