Remove old routers and axelar relayer #1953
Conversation
lemunozm
added
P7-asap
| @@ -29,21 +29,18 @@ | |||
| use core::fmt::Debug; | |||
|
|
|||
| use cfg_primitives::{LP_DEFENSIVE_WEIGHT, LP_DEFENSIVE_WEIGHT_REF_TIME}; | |||
| use cfg_traits::{ | |||
There was a problem hiding this comment.
@cdamian sorry, I've needed to remove some lines from the gateway, but because they are removed lines, I think the git conflicts are easy to solve, by just applying always these changes in these files
There was a problem hiding this comment.
No problem, as long as there are no big changes to the actual gateway logic, we can manage. Thank you!
|
|
||
| /// A generic router used for executing XCM calls. | ||
| #[derive(Debug, Encode, Decode, Clone, PartialEq, Eq, TypeInfo, MaxEncodedLen)] | ||
| pub struct XCMRouter<T: pallet_xcm_transactor::Config> { |
There was a problem hiding this comment.
Given that we "might" use xcm in the future, would it make sense to keep this here and minimally maintain this when doing polkadot version updates etc.? I'm thinking that re-doing an xcm setup from scratch might be even more troublesome later on.
There was a problem hiding this comment.
In the incoming refactor, this routers module will disappear. We no longer can have "outbound" routers without an "inbound" router. In case we need this logic to build a bidirectional XCM router in the future, we can just look in this PR and recover that logic to build that new router.
Note that XCM is still used by the chain, just that not by the that router.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1953 +/- ##
==========================================
- Coverage 48.06% 47.68% -0.38%
==========================================
Files 183 181 -2
Lines 12906 12766 -140
==========================================
- Hits 6203 6088 -115
+ Misses 6703 6678 -25 ☔ View full report in Codecov by Sentry. |
lemunozm
force-pushed
the
clean/old-routers
branch
from
eba2f80 to
408be79
Compare
There was a problem hiding this comment.
More than 2000 lines less simplifies a lot! I was a bit sceptical about removing the RelayerList storage but seeing it is empty on Centrifuge Chain, seems fine! Let's merge this PR before #1947 because the latter is low prio.
|
Wai yours then, or did you say the opposite? 😆 |
No! Sorry, I phrased my message poorly. Please merge your PR first. |
Description
This PR remove the no longer used routers, cleaning the codebase for the incoming router refactor.
2 main concepts are removed from the codebase:
EthereumXCMandAxelarXCMrouters.