LPv2: UTs for Batches #1952
Merged
LPv2: UTs for Batches #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
commented
Aug 8, 2024
Comment on lines
-511
to
-512
| let weight = Weight::from_parts(0, T::Message::max_encoded_len() as u64) | ||
| .saturating_add(LP_DEFENSIVE_WEIGHT); |
There was a problem hiding this comment.
The defensive weight shadows the length of a message PoV. Anyways the max_encoded_len is not used here in any storage. Just process the content of the message, which is not dependent of the bytes of the message
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1952 +/- ##
==========================================
+ Coverage 47.83% 47.90% +0.07%
==========================================
Files 183 183
Lines 12904 12902 -2
==========================================
+ Hits 6172 6181 +9
+ Misses 6732 6721 -11 ☔ View full report in Codecov by Sentry. |
cdamian
approved these changes
Aug 9, 2024
lemunozm
force-pushed
the
lpv2/batch-uts
branch
from
78dddfb to
77913f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add UTs for batches