feat: add freeze & unfreeze extrinsics #1947
Conversation
wischli
added
I5-documentation
| }) | ||
| } | ||
|
|
||
| /// NOTE: Collecting redemptions does not check pre-conditions |
There was a problem hiding this comment.
pallets/investments/src/tests.rs
Outdated
| TestExternalitiesBuilder::build().execute_with(|| { | ||
| assert_noop!( | ||
| Investments::collect_investments(RuntimeOrigin::signed(NOT_INVESTOR), INVESTMENT_0_0), | ||
| DispatchError::Other("PreCondition mock fails on u64::MAX account on purpose") |
There was a problem hiding this comment.
Nit - move this error to a const and use it in the mock and tests.
pallets/liquidity-pools/src/lib.rs
Outdated
| false, | ||
| )?; | ||
|
|
||
| T::Permission::add( |
There was a problem hiding this comment.
Any specific reason this is not implemented in the same way as update_member: the permission is set separately using the permsisions.add_permission extrinsic, and then in the liquidity pools method it is just checked that the permission is already set?
There was a problem hiding this comment.
Great point. I will refactor it to be in sync with the update_member flow!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1947 +/- ##
==========================================
+ Coverage 47.83% 48.31% +0.48%
==========================================
Files 183 184 +1
Lines 12904 12999 +95
==========================================
+ Hits 6172 6281 +109
+ Misses 6732 6718 -14 ☔ View full report in Codecov by Sentry. |
wischli
added
the
D8-migration
Description
PoolrolevariantFrozenTrancheInvestorTrancheInvestorpermission with downside of having to migrate all existing storage entriespallet-liquidity-poolspallet-liqudiity-poolsdefensive weightsChecklist: