Mock builder update. Improved FI coverage #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdamian
reviewed
Aug 2, 2024
| cfg-mocks = { workspace = true, default_features = true } | ||
| frame-system = { workspace = true, default_features = true } | ||
| mock-builder = { workspace = true, default_features = true } | ||
| cfg-mocks = { workspace = true, default-features = true } |
There was a problem hiding this comment.
Oh I just noticed the difference here. This is scary lol
There was a problem hiding this comment.
And no warnings at all by cargo 😅
|
I've needed to also update all inner dependencies to get rid of a cargo bug 🫤 |
cdamian
previously approved these changes
Aug 2, 2024
lemunozm
commented
Aug 5, 2024
Comment on lines
30
to
33
| + 'static, | ||
| ) { | ||
| register_call!(move |(a, b, c, d, e)| f(a, b, c, d, e)); | ||
| ) -> CallHandler { | ||
| register_call!(move |(a, b, c, d, e)| f(a, b, c, d, e)) | ||
| } |
There was a problem hiding this comment.
Basically, if you leave the ; then the behavior is the same as before. If you remove the ;, then the CallHandler is returned, and you have the new capabilities
lemunozm
force-pushed
the
mock-builder-handler
branch
from
89d4a92 to
f858bbd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1945 +/- ##
=======================================
Coverage 47.72% 47.73%
=======================================
Files 184 184
Lines 12969 12969
=======================================
+ Hits 6190 6191 +1
+ Misses 6779 6778 -1 ☔ View full report in Codecov by Sentry. |
cdamian
approved these changes
Aug 5, 2024
hieronx
approved these changes
Aug 5, 2024
|
Could you force @hieronx ? It seems like we also need the Frederik approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
default-features(I do not know why Cargo did not complained)Cargo updateSomething is really off with the cargo update. Just doingcargo updateonmainmakes the compilation of runtime fail due to std issues. I was not able to find the guilty one.